Skip to content

Fix remote function discovery during prerendering - #16829

Closed
teemingc with Copilot wants to merge 2 commits into
skip-ssr-buildfrom
copilot/fix-github-actions-job-failure
Closed

Fix remote function discovery during prerendering#16829
teemingc with Copilot wants to merge 2 commits into
skip-ssr-buildfrom
copilot/fix-github-actions-job-failure

Conversation

Copilot AI commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The cross-browser build job did not fail when a prerender remote function threw. The Vite-backed prerender server read its manifest before route components had populated remote-function entries.

  • Prerender manifest initialization
    • Resolve route nodes and load their components before reading manifest._.remotes.
    • Preserve existing tolerant component-loading behavior used during route analysis.
const nodes = await Promise.all(manifest._.nodes.map((loader) => loader()));

for (const node of nodes) {
	await node.component?.();
}

This allows prerender remote functions to be queued and their HTTP failures to correctly fail the build.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 17, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 18c14bb:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/18c14bbfd726f07baaabf7e54eb2c1d8c74258b6

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16829

@changeset-bot

changeset-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 18c14bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Fix remote function discovery during prerendering Aug 17, 2026
Copilot AI requested a review from teemingc August 17, 2026 11:34
@teemingc

Copy link
Copy Markdown
Member

Closing so I can manually add the solution to the existing PR

@teemingc teemingc closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants